Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Energy scan #283

Merged
merged 7 commits into from
Feb 10, 2025
Merged

Energy scan #283

merged 7 commits into from
Feb 10, 2025

Conversation

stu247
Copy link
Contributor

@stu247 stu247 commented Feb 8, 2025

Adding ability to run an energy scan. This is the same scan that runs when downloading ZHA diagnostics file.

@stu247 stu247 requested a review from mdeweerd as a code owner February 8, 2025 21:27
@mdeweerd
Copy link
Owner

mdeweerd commented Feb 8, 2025

thank you for sharing.

I updated the code for code style (mainly pre-commit supported).

You can check it still works and if you confirm I'll integrate it.

I'ld consider (an optoin) to append to the CSV file rather than overwriting it each time.
I'ld also consider adding a timestamp to the CSV file output.

@stu247
Copy link
Contributor Author

stu247 commented Feb 9, 2025

I have an update for README.md that I plan to push tomorrow. I also have another branch for updates to zha_devices. I have added the ability to save the output to a json file. Plan to do a PR tomorrow.

@stu247
Copy link
Contributor Author

stu247 commented Feb 10, 2025

It looks like the pre-commit workflow is automatically removing the double quotes around

entity_id: "input_number.zigbee_energy_channel_{{ repeat.item }}"

in README.md. I think these quotes are needed in order to process the {{ }} correctly. How can this be fixed?

@mdeweerd
Copy link
Owner

Fixed the removal of the quotes it by removing the 'yaml' format hint.
This was done by mdformat-config and can't be configured.
(Its' configured for prettier in .prettierrc)

@mdeweerd mdeweerd merged commit c31ad40 into mdeweerd:main Feb 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants